Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: e0ea042 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
eluce2
requested changes
Mar 23, 2026
Collaborator
eluce2
left a comment
eluce2
left a comment
There was a problem hiding this comment.
add a changeset to cause a package bump
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated localized template string catalogs for the ProofKitWV addon across 11 locales: added seven new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
packages/cli/template/fm-addon/ProofKitWV/pt.xml (1)
135-140: Add a locale parity check to prevent future catalog drift.Because these updates are replicated across many locale XML files, add a CI check that validates identical
StringIDsets acrosspackages/cli/template/fm-addon/ProofKitWV/*.xml.Also applies to: 457-462, 520-525, 835-840, 1003-1008, 1073-1078, 1297-1302
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/template/fm-addon/ProofKitWV/pt.xml` around lines 135 - 140, Add a CI check that validates locale parity by ensuring every XML under packages/cli/template/fm-addon/ProofKitWV/*.xml contains identical sets of <StringID> entries (e.g., com.fmi.calculation.text.099EE24B07E075A063F3607A43895372 and the others referenced) to prevent catalog drift; implement a script (run in CI) that parses each XML, extracts all StringID values, compares the sets across files, and fails the build if any file has missing or extra StringID entries, reporting which filenames and which StringID keys differ.packages/cli/template/fm-addon/ProofKitWV/ko.xml (1)
1297-1302: Consider translating this user-facing text forko.xml.
mac only right nowappears to be explanatory text rather than a code token. If this surfaces in UI/docs for Korean users, consider a Korean target string.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/cli/template/fm-addon/ProofKitWV/ko.xml` around lines 1297 - 1302, The DynamicTemplateString with StringID com.fmi.scriptstep.text.726655869DF5DF4378CBF8E94FAAC20D in ko.xml currently uses the English phrase "mac only right now"; replace the TargetText value with an appropriate Korean translation (and update the Comment if needed) so the user-facing explanatory text is localized; locate the DynamicTemplateString block for that StringID and edit TargetText to a natural Korean phrase matching the SourceText.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@packages/cli/template/fm-addon/ProofKitWV/ko.xml`:
- Around line 1297-1302: The DynamicTemplateString with StringID
com.fmi.scriptstep.text.726655869DF5DF4378CBF8E94FAAC20D in ko.xml currently
uses the English phrase "mac only right now"; replace the TargetText value with
an appropriate Korean translation (and update the Comment if needed) so the
user-facing explanatory text is localized; locate the DynamicTemplateString
block for that StringID and edit TargetText to a natural Korean phrase matching
the SourceText.
In `@packages/cli/template/fm-addon/ProofKitWV/pt.xml`:
- Around line 135-140: Add a CI check that validates locale parity by ensuring
every XML under packages/cli/template/fm-addon/ProofKitWV/*.xml contains
identical sets of <StringID> entries (e.g.,
com.fmi.calculation.text.099EE24B07E075A063F3607A43895372 and the others
referenced) to prevent catalog drift; implement a script (run in CI) that parses
each XML, extracts all StringID values, compares the sets across files, and
fails the build if any file has missing or extra StringID entries, reporting
which filenames and which StringID keys differ.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5d3ea178-f50b-41ea-8b13-722c91d38b0b
📒 Files selected for processing (24)
fm-addon/ProofKit.fmp12packages/cli/template/fm-addon/ProofKitWV/de.xmlpackages/cli/template/fm-addon/ProofKitWV/en.xmlpackages/cli/template/fm-addon/ProofKitWV/es.xmlpackages/cli/template/fm-addon/ProofKitWV/fr.xmlpackages/cli/template/fm-addon/ProofKitWV/it.xmlpackages/cli/template/fm-addon/ProofKitWV/ja.xmlpackages/cli/template/fm-addon/ProofKitWV/ko.xmlpackages/cli/template/fm-addon/ProofKitWV/nl.xmlpackages/cli/template/fm-addon/ProofKitWV/pt.xmlpackages/cli/template/fm-addon/ProofKitWV/records_de.xmlpackages/cli/template/fm-addon/ProofKitWV/records_en.xmlpackages/cli/template/fm-addon/ProofKitWV/records_es.xmlpackages/cli/template/fm-addon/ProofKitWV/records_fr.xmlpackages/cli/template/fm-addon/ProofKitWV/records_it.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ja.xmlpackages/cli/template/fm-addon/ProofKitWV/records_ko.xmlpackages/cli/template/fm-addon/ProofKitWV/records_nl.xmlpackages/cli/template/fm-addon/ProofKitWV/records_pt.xmlpackages/cli/template/fm-addon/ProofKitWV/records_sv.xmlpackages/cli/template/fm-addon/ProofKitWV/records_zh.xmlpackages/cli/template/fm-addon/ProofKitWV/sv.xmlpackages/cli/template/fm-addon/ProofKitWV/template.xmlpackages/cli/template/fm-addon/ProofKitWV/zh.xml
Contributor
Author
|
changeset added |
eluce2
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit